...since the SdrInsertReason ctor lost its second parameter in
1d852b32 "loplugin:unusedmethods svx"

Change-Id: I2db0b5b87c50c29113f7a9ef2de065ee32cce8d7

There is a sort of intentional infinite loop in the idle spell checking
handler: while the user is typing a word, it should not be marked as
invalid yet, in order not to annoy them with red underlines.

So the word where the cursor is positioned always remained dirty, unless
you happen to have a grammar checker enabled, which clears the
paragraph's dirty flag from a separate thread.

To avoid the infinite loop, add another spell checking state "PENDING"
which is the same as dirty except that it should cancel the idle spell
checking.

The idle spell checking will run again when the user does the next
editing operation.  Notably this means if the user just moves the cursor
out of the wrongly spelled word, it won't be underlined yet, but that
appears a minor issue, and checking when the cursor leaves the word
appears too hard to implement.

Change-Id: Ifb3d6d17f94f9f1cfad82e70dfa79f1594c38647

...ever since

  nTol=0; // Joe am 6.3.1997: Keine Hittoleranz mehr hier

had been added into it sometime prior to
fd069bee "initial import."  So lets assume Joe
meant that as a permanent fix rather than a temporal hack (which would have
survived for longer than 18 years anyway).

Change-Id: Ib30ac8d578f70c861d4c0f5f71bf4c13e9281db8

Change-Id: I728d4c0c6e271e3a97a95996f96ed43c00a3abc8

Regression from commit 6d64d2f3 (Minor
refactoring and cleanup of Scheduler and Timer., 2015-07-19), the old
Timer::ImplStartTimer() used to set nMS to at least 1, but the new
Scheduler::ImplStartTimer() didn't do that.

With this, JunitTest_sw_unoapi_3 no longer hangs for me.

Change-Id: I16ad360f1e5430cde7ec8b28e8c2620d260c9ec0

Change-Id: I525009b9d037387b236cb4605fe0b93c94858d89

These warnings are too annoying. So sue me.

This reverts commit 5c60dab3.

...ever since that block of code got added into SdrCreateView::EndCreateObj with
b3a18f15 "#83403# Use one common method for
inserting scenes into scenes."

Change-Id: Icd89d5ef2fa0601f82fa4b7d7610c709d49269af

...ever since 2cb4c646 "CWS-TOOLING: integrate
CWS frmdlg"

Change-Id: I5ba64a9e8005efc5e918669d0ef3119c18c32594

Change-Id: I1bab95a9a3db765d3b3bd34345dc006ccd33caf0

..in 9ed1dd01 "tdf#90839: support for wrapped
text in data labels and for centered data value" by moving the additional
optional property to the end; also, add missing @since tags

Change-Id: I6f8a6cb22d29ba27a109089892b8df009d1043db

...4b4a7c0d "Revert a fix that can never have
worked in the first place?"---which presumably did work after all, as Noel
thankfully pointed out to me,
<http://lists.freedesktop.org/archives/libreoffice/2015-September/070193.html>
"Re: [Libreoffice-commits] core.git: basic/source 'Revert a fix that can never
have worked in the first place?'"

Change-Id: I411bfaacbfebf50589290c6a3040d0300c256439

Change-Id: Id0be728602b3c58b2853ff464336d68303531efe

(a use of nStyleNo at the end of SvxRTFParser::ReadAttr had been in a commented-
out clode block ever since fd069bee "initial
import," and later been cleaned from the code)

Change-Id: Ic9e30cc1bccca9c4246deb50fbc6d545e3ea31a2

with the variadic variants.

Change-Id: I1c423f98fba55c1ac5c3bd9a4e81ebd7eb6604b4
Reviewed-on: https://gerrit.libreoffice.org/18393Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

with the variadic variants.

Change-Id: I0e4c7e26af86806e75bb75b7eb6c70b57e1c9514
Reviewed-on: https://gerrit.libreoffice.org/18427Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

with the variadic variants.

Change-Id: I43d586da78976c33557e66ced9782ac7adb8dc77
Reviewed-on: https://gerrit.libreoffice.org/18428Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I5a7c42aff29277a8189dc00a4a3a185d3a8d3021

with the variadic variants.

Change-Id: I6c77b9219c772f38005431fed7cd0f4132fab2b9
Reviewed-on: https://gerrit.libreoffice.org/18395Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Id9098c07d7aff62adb26165611a545efcfe87a34
Reviewed-on: https://gerrit.libreoffice.org/18419Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I3127752785b77672d37f99bc9eaa881377dabe7c
Reviewed-on: https://gerrit.libreoffice.org/18431Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I8832a303ae2ac384e49488835df6b2d145ebbfcd
Reviewed-on: https://gerrit.libreoffice.org/18430Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ifed1a8cfa774225cb450bb211b1b1b949ef02811
Reviewed-on: https://gerrit.libreoffice.org/18429Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

...uselessly introduced with 94cac4c5 "changed
to new clipboard interface"

Change-Id: I4e446c7e524f1c80fe82d699d8c16e5cfa59932c

Change-Id: I2f36a123662488ef5534f7bf0845d61e497fb0ec

Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b

Change-Id: I4fba6bf5b34b086a11659de3cddf46c76007a147

Change-Id: I184d836e944d6dcfd17233a7a83680f1c1bff9bf

Change-Id: I49bf8192a2f5295890ead8ddc2452a5de4c93b20

Fix warning: elide construction of rtl::OUString with string constant
argument in call of rtl::OUString::operator=.

Change-Id: I5017509c04381fb158da1ceede7c8bef564f1c07

Now in a pie chart the text of a label can be wrapped, the wrapping is
automatic and the maximum text width is fixed to almost half the pie
radius. This feature is used to import correctly the relative text
wrapping property provided by MSO.

Moreover the data value and percent value of a label are now centered
horizontally, respect with the label text.

Conflicts:
	chart2/qa/extras/xshape/chart2xshape.cxx

Change-Id: Ie10d6184365436f763cd9693a5bbefcfa9b3862b
Reviewed-on: https://gerrit.libreoffice.org/17193Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I327108c72d6f00575491de8ee1ebc470e6d18bb5

Elide construction of rtl::OUString with string constant argument in
call of rtl::operator+.

Change-Id: Ic5bce873550d9755094bbd5a0867994d1670e02a

...that rather trivially wrapped some osl/diagnose.h functionality

Change-Id: I4105708488114a9c87aa415affb997a783241248

In many cases it was originally used to silence warnings about variables used
only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is
based on SAL_WARN etc.  In some other cases it was apparently used as a
speculative debugging aid, to have a value assigned to a variable to be easily
able to view the value in a debugger.  And in some cases it was used with
(otherwise ignored) return values of (typically SQL-related) function calls, but
it is probably better to eventually find and fix all the problematic ones among
such calls via function declarations annotated SAL_WARN_UNUSED_RESULT.

Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf

Change-Id: I1b72a95b7367bb555d37a9a073ca4da2b01cf53f

Change-Id: Id990e30019a0a1d94755227edeee3cb01fc0e870
Reviewed-on: https://gerrit.libreoffice.org/18416Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I33618d35285506798492a96af98fc8d7edff9173
Reviewed-on: https://gerrit.libreoffice.org/18415Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ifedea7c26689a2760b6ba9ee4713f942c62bbdab
Reviewed-on: https://gerrit.libreoffice.org/18417Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Idc95d4b8acae9dcd4ed0092c43986e6687f06c11