That is a too complex and rare case to bother with, I think.

Change-Id: Ica6ef7fa05314d2367dcff32627c1aec6ba8f8df
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I46e5463aaa5cab41cd69c13314ee98a0c73e7ba2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I6b19873eef48b625dc3d4f7b3a9afdb348189b38
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Icab5608900108c89e649e78a2e35d02e941d0ac0
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

The text alignment of DCs is set to TA_BASELINE in
WinSalGraphics::InitGraphics(). In the ScriptTextOut-using old code
path this affects where glyphs are put, so we need to take it into
consideration also in the new code path that uses cached glyph
textures. Adjusting the position up by the ascent plus internal
leading of the font seems to work at least for horizontal scripts.

(We used to bluntly adjust the position up by the height of the glyph
cache texture, which was too much. The glyphs got positioned too high
and the top of tall ones was clipped.)

Change-Id: I86aecd6f3016e14b2f0328555ddfd3129e394c4c
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Id023b43e901b0e41ebf3b208c6e80fd023bf7f9a
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Show the whole height of the cache bitmap after all (when SAL_LOG
contains vcl.gdi.opengl). The interesting pieces are often at the
bottom, like the tip of the hook of the "j" glyphs that used to bleed
over into the preceding glyphs, usually "i", when they were rendered
into the same chunk.

Add more space between glyphs and at top and bottom of the bitmap, for
anti-aliasing. The glyph ABC widths don't take expansions caused by
anti-aliasing into consideration and are misleading. Hopefully
anti-aliasing can expand the (partially) painted pixels of a glyph
just one column/row in each direction, but for safety use a two-pixel
border. (Defensive programming, eek?)

Some getWidth() instead of GetWidth() etc craziness. Using
<tools/gen.hxx> types truly is programming-by-coincidence as Thorsten
says.

In a dbgutil build, setting the environment variable
VCL_GLYPH_CACHING_HACK_NO_ANTIALIAS causes the code to turn off
anti-aliasing for the fonts used. I used this to verify that it indeed
was anti-aliasing that made the ABC widths inconsistent with
reality. Not sure if it makes sense to keep this code in?

Anyway, now I don't see any leaked pixels in "i" glyphs any more,
touch wood.

Change-Id: If527343ff1dcdb1fa208cd5e7fa4d08f812d0d7b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I29cb771eb059f560b7cbd449257ffda581b40f11
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I59dbfea2230012447732d12f732ad160a30908e7
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I934ad7453f35909f4c3ad999e33453b5b6032480
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Now text looks better, for instance the lower-case "t" glyphs on the
Start Centre aren't totally weird any more. But for instance the tip
of the hook of "j" leaks into the "i" texture. I guess I really would
need to render glyphs one by one.

Change-Id: I69ae2d2f7c559530bcfdfc1a4915503fcb3ab4af
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I0bbea4ef62c8e94d8b8f1bfb440712da5839e532
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Shows text roughly correctly, but many problems. Conditional at
run-time on the SAL_ENABLE_GLYPH_CACHING environment variable in
addition to SAL_FORCEGL.

One obvious thing that needs fixing is making sure that the glyphs are
rendered into the texture without overlap. Compensating negative
values in the ABC::abcA and ABC::abdC width is not enough.

Also, the cache should be changed to actually have "cache"
functionality, i.e. entries should expire based on some criterion.

Change-Id: I66a37d3354a09011a654f15a7d2bd8efaa14ad1e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Is comphelper the right place for this? Is having it as "inline" the right
way?

Change-Id: I973dbde108f89b6cab17e5d88db2390d6f18a672
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Ia41882a4d33e7b148044801902517b2b034d3ee4
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Use Uniscribe also for non-complex text. It is complicated enough to
have separate Graphite and Uniscribe layout engines. Will make further
changes to the code easier to manage, especially as with the
UniscribeLayout code we have access to the actual
glyphs. (Cf. 3e47219e)

Change-Id: I9c67c172fe3e3d26d1c6cb1c0b7f1516b0b87f12
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Remove dead code. Should have no effect on behaviour.

Possibly originally the intent was that mbDisableGlyphs would have
been false in most cases on NT-based Windows (all versions that we
support now). However, since dadfc608,
in 2005, mbDisableGlyphs was set to always true in the SimpleWinLayout
ctor.

Change-Id: Id929224d5656706762c2f44ee26c76f8b20ee8b8
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

It is really ugly to use SAL_OVERRIDE inconsistently.

Change-Id: I8b556a9cc65e6f71198d126d07ce1559216543e9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I0d0cb1ef1e7b7f4747204b84c7c910f174e9c7b5
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I2b6ded138b9101415fc49e93e1ec3ebcd3a9d2ae
(cherry picked from commit 5ed690a3)
Reviewed-on: https://gerrit.libreoffice.org/18099Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I358758999bb918e73cdee2224e575e72c2131453
(cherry picked from commit 0c713e45)
Reviewed-on: https://gerrit.libreoffice.org/18098Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I60d3388ece28a69c31a85b9e3b495cbe8a03e7dc
(cherry picked from commit 42732d25)
Reviewed-on: https://gerrit.libreoffice.org/18097Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: Ia593dd0e2239a97f17bb03f005d22028da482445
(cherry picked from commit d400f155)
Reviewed-on: https://gerrit.libreoffice.org/18096Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

moz323894-1.tiff and moz456356-1.tiff take too long to load

Change-Id: Iaafa064fd05e4a4152004e7ceb6256af68aeef01
(cherry picked from commit 7e373e92)
Reviewed-on: https://gerrit.libreoffice.org/18095Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

the paste special listener listens to owner changed, but expects
the owner changed event to contain the new contents, while the
original code expected getContents to be explicitly called to get
the new contents. So on owner changed always return the up to
date contents

Change-Id: Iaa7df2c01d360c3c5831b2258b4c2d41740fdffc
(cherry picked from commit 26786ae2)
Reviewed-on: https://gerrit.libreoffice.org/18054Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

As agreed in the bug report, a preview shouldn't be
themed by the OS theme.

(cherry picked from commit fa1807ad)

Conflicts:
	include/svx/numvset.hxx
	svx/source/dialog/svxbmpnumvalueset.cxx

Change-Id: Icdc5021c3ac614fe1d490fd513a407a81dbc169e
Reviewed-on: https://gerrit.libreoffice.org/18068Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

... in a style with family "paragraph", as detected by a
--with-export-validation build due to the unit test added yesterday.

So use the loext namespace for the style:graphic-properties element,
and also omit it entirely (and rely on the style:paragraph-properties
attributes fo:background-*) if the ODF version is set to 1.2 or 1.1.

Also adapt a previous check that was missing the "drawing-page" style
family, where the style:graphic-properties is allowed (commit
9746dc9a)

(regression from 7d9bb549)

Change-Id: Iedd66483f63020328bd61e1c1e19c62787b8ff6b
(cherry picked from commit b1922eec)
Reviewed-on: https://gerrit.libreoffice.org/18064Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Just invert the scrollbar the same way gtk+ does by checking the
button positions and adjust the drawing style accordingly.

Change-Id: I3475c33e074c1509a73da618a4efa44dc61a1a77
(cherry picked from commit 273df176)
Reviewed-on: https://gerrit.libreoffice.org/18033Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f
(cherry picked from commit c249f93d)
Reviewed-on: https://gerrit.libreoffice.org/18052Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Silence the glibc compile warning and actually handle a wrong
return value.

Change-Id: Icdbc8e655d4b8ad20699dfd0abdbf3405a49f898
(cherry picked from commit e4a3bf06)
Reviewed-on: https://gerrit.libreoffice.org/18034Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I50e07779a541bbea6b285a855fb54d419d4aed13
(cherry picked from commit 52a52a21)

This reverts commit 350b00af.

Breaks CppunitTest_sc_subsequent_filters_test

Change-Id: I92963fa16aacbf01f4d6660eff7497347538371d
Reviewed-on: https://gerrit.libreoffice.org/18029Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I9c384587c127ca077803bf8aae63d0e54eda6aaf
(cherry picked from commit be95c743)
Reviewed-on: https://gerrit.libreoffice.org/18025Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7
(cherry picked from commit a8b2dc80)
Reviewed-on: https://gerrit.libreoffice.org/18024Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I288f7ff0327831603eda6e827c8acbae678dfaff
(cherry picked from commit cadac840)
Reviewed-on: https://gerrit.libreoffice.org/18017Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I544a67e3706c7d12414cc075118ef2f0f5ddd0f6
(cherry picked from commit 334dba62)
Reviewed-on: https://gerrit.libreoffice.org/18015Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

just shove the unneeded pam into dead space

Change-Id: Id0a3d550cd9d54394888e6b2d62e21eaded24a7c
(cherry picked from commit d9edac5d)
Reviewed-on: https://gerrit.libreoffice.org/17998Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

so do that in the ctor and drop the arg from a bunch of places

(cherry picked from commit 3d992d77)

Change-Id: Iaad71e9854b38d8632df057dfe9c96468d1d0098
Reviewed-on: https://gerrit.libreoffice.org/17997Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Build ID will show enabled OpenGL with an extra string "-GL"
helping the fix of rendering issues.

Change-Id: Id7bf2db2edb165542bf7a2a253c698c494278a03
Reviewed-on: https://gerrit.libreoffice.org/18014Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

For example, "B2:" or ":B2" were accepted as valid range, with the
missing part set to A1, which resulted in a A1:B2 range.

An omitted sheet specifier always results in a valid relative sheet,
hence that flag is set, so testing flags for non-null before the final
result is available isn't sufficient.

Change-Id: I57d1b7cf71a298e7ac108b0e13aab88208f0f00c
(cherry picked from commit ed6209f5)
Reviewed-on: https://gerrit.libreoffice.org/18023Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>